Skip to content

fixed#1348

Open
ArshiBansal wants to merge 2 commits into
magic-peach:mainfrom
ArshiBansal:footer_fix
Open

fixed#1348
ArshiBansal wants to merge 2 commits into
magic-peach:mainfrom
ArshiBansal:footer_fix

Conversation

@ArshiBansal
Copy link
Copy Markdown

Description

This PR improves the Footer component by enhancing layout structure, responsiveness, accessibility, and overall visual hierarchy. The footer has been refactored to provide a more balanced design across different screen sizes and improve usability for navigation and community engagement.

Key improvements:

Refactored grid layout for better spacing and alignment across large screens
Improved responsiveness for mobile, tablet, and desktop views
Replaced “Stay Tuned” toggle with a functional newsletter subscription form
Added proper aria-label attributes for all icon-only and interactive elements
Improved focus states using focus-visible for better keyboard accessibility
Enhanced visual hierarchy for Navigation, Updates, and Community sections
Improved hover and interaction feedback for links and social icons
Better spacing consistency and section separation for cleaner UI

Related Issue

solves issue: #1310

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • [.] Refactor
  • [.] GSSoC contribution

Participant Info

  • GitHub username: ArshiBansal
  • Contribution level (Beginner/Intermediate/Advanced): Beginner

Screen Recording

How to record: run bun run dev → open http://localhost:3000 → demonstrate the full working flow of your change, including any edge cases.

  • macOS: Cmd + Shift + 5 → Record Selected Portion, or use QuickTime Player
  • Windows: Win + G → Xbox Game Bar → Capture
  • Linux: OBS Studio, GNOME Screenshot tool, or kazam
  • Any OS: Loom (free screen recorder, great for sharing)

Recording / Loom link: ## Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

@ArshiBansal is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

⚠️ PR Format Issues — @ArshiBansal

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README
  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @ArshiBansal!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels May 28, 2026
@ArshiBansal
Copy link
Copy Markdown
Author

@magic-peach please merge the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant